User-Agent Fix for OrangeDrangon/android-messages-desktop#441 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified how the user agent is set when sending headers. There were two issues that I was able to identify. First, the Google sign-in page sends requests to the youtube.com domain sometimes, so the existing replacement effect was not always firing. Adding a url entry for this domain fixes this problem. Second, Google sometimes doesn't like the hard-coded user agent this project was previously providing. I have no idea why -- this Electron/user agent/Google problem has been ongoing for years. I've solved this problem this time by instead taking the user agent Electron would have passed by itself and stripping out only the Electron-specific component. I don't know how long this fix will last, since Google seems intent on being opaque about how they determine if a browser is secure or not. Fingers crossed.
|
@drislands thanks for the patch will get it released once the checks finish |
|
@OrangeDrangon Thank you! Glad I was able to help. |
|
@OrangeDrangon I just saw one of the checks failed with an "already_exists" error code -- is this something I should have seen and fixed before the PR? I'm not sure what the solution is but I'll do whatever it needs to make it work. |
|
No that was a problem with the ci pipeline.
Thanks
Kyle
Sent with Shortwave <https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=a3lsZUBla3Jvc2VuYmVyZy5jb20=>
…On Sat Jun 8, 2024, 09:22 PM GMT, drislands ***@***.***> wrote:
@OrangeDrangon <https://github.com/OrangeDrangon> I just saw one of the checks failed with an "already_exists" error code -- is this something I should have seen and fixed before the PR? I'm not sure what the solution is but I'll do whatever it needs to make it work.
—
Reply to this email directly, view it on GitHub <#450 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGB2A7LKNVPMKDMOQYCBUXTZGNYYLAVCNFSM6AAAAABJAA5OMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJWGE4DQNZZGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified how the user agent is set when sending headers. There were two issues that I was able to identify.
First, the Google sign-in page sends requests to the youtube.com domain sometimes, so the existing replacement effect was not always firing. Adding a url entry for this domain fixes this problem.
Second, Google sometimes doesn't like the hard-coded user agent this project was previously providing. I have no idea why -- this Electron/user agent/Google problem has been ongoing for years. I've solved this problem this time by instead taking the user agent Electron would have passed by itself and stripping out only the Electron-specific component.
I don't know how long this fix will last, since Google seems intent on being opaque about how they determine if a browser is secure or not. Fingers crossed.