-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header option per request #3576
Add header option per request #3576
Conversation
5c2c5eb
to
9349ff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is perfect @theoforger ! What we could do, in another PR, is adding a variable that will be used in the additional headers:
Command line:
$ hurl --header "test: from-cli" --variable my_header=from-var tests_ok/header_option.hurl
Hurl file:
...
# in the same request
[Options]
...
header: {{my_header}}
(no issue needed as it's just code improvement)
/accept |
🕗 /accept is running, please wait for completion. |
* Remove `cli-only` * Add `header` in the `options` field * Add integration test for header option
🔨 Auto rebase from
|
🕗 /accept is still running, please wait for completion. |
9349ff3
to
17d8dc5
Compare
✅ Pull request merged with fast forward by
|
@jcamiel Thanks! I'll work on this next 👍 Slightly off topic: I'm taking a course this semester which requires us to get involved in an open source project. It expects us to regularly work on the project, get to know the code and the community. I've really enjoyed working with you guys so far, and I wonder if I can continue my work here? Thanks for the consideration! 😆 |
Yes of course @theoforger! There are the issues labelled "good first issues" (the label is more a link of "relatively easy issue" to work on, instead of "first issues"). You can look at this list. Among them for instance:
You can look of course at any other issue if you're more interested in it. Just ping me on one at I'll give you some direction f you need |
Closes #3575.
Description
This PR adds a
header
option to the hurl file's[Options]
field, along with the integration test for this new feature.Note
I also regenerated the
grammar.md
file using the latest build of fabricereix/grammar.