Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Erc20Wrapper extension #498

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

feat: Erc20Wrapper extension #498

wants to merge 29 commits into from

Conversation

Ifechukwudaniel
Copy link
Contributor

@Ifechukwudaniel Ifechukwudaniel commented Jan 16, 2025 •
edited
Loading

Resolves #354

PR Checklist

  • Tests
  • Documentation
  • Changelog

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit 1b15a10
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/679c192eb84b7f00081d51ee
😎 Deploy Preview https://deploy-preview-498--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.

Project coverage is 86.6%. Comparing base (e005e5b) to head (4070411).

Files with missing lines Patch % Lines
contracts/src/token/erc20/extensions/wrapper.rs 0.0% 91 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc20/extensions/wrapper.rs 0.0% <0.0%> (ø)

@Ifechukwudaniel Ifechukwudaniel marked this pull request as draft January 16, 2025 01:36
@Ifechukwudaniel Ifechukwudaniel changed the title Erc20 wrapper [FEATURE] Erc20Wrapper Jan 24, 2025
@bidzyyys bidzyyys changed the title [FEATURE] Erc20Wrapper feat: Erc20Wrapper extension Jan 27, 2025
bidzyyys
bidzyyys reviewed Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progess @Ifechukwudaniel, please focus on now:

  • Increasing E2E test coverage
  • Improving Rust docs
  • Solving all clippy warnings.

contracts/src/token/erc20/extensions/wrapper.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/wrapper.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/wrapper.rs Outdated Show resolved Hide resolved
contracts/src/token/erc20/extensions/wrapper.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/wrapper.rs Show resolved Hide resolved
contracts/src/token/erc20/extensions/wrapper.rs Show resolved Hide resolved
examples/erc20-wrapper/tests/erc20wrapper.rs
// ============================================================================

#[e2e::test]
async fn constructs(alice: Account) -> Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase E2E test coverage.

bidzyyys
bidzyyys reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ifechukwudaniel CI does not pass. Please fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys left review comments

@qalisander qalisander Awaiting requested review from qalisander qalisander is a code owner

@0xNeshi 0xNeshi Awaiting requested review from 0xNeshi 0xNeshi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: ERC20Wrapper extension
2 participants
@Ifechukwudaniel @bidzyyys