-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Investigate Fuzzing #477
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
9d8cb5f
to
3075679
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
openzeppelin_crypto::merkle::Verify
95c1b31
to
a996ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the scenarios, great job @0xNeshi!
Left some comments.
@0xNeshi we should consider fuzzing for this folder -> https://github.com/OpenZeppelin/rust-contracts-stylus/tree/main/contracts/src/utils/math |
Definitely 💯 We will need shims for this to work though, I'd suggest we hold off on this for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As per our agreement, this PR includes a basic fuzz tests setup and some missing unit/property tests for
openzeppelin-crypto
crate.I created a couple of related issues to address missing property tests (see #501 #502 #503).
Adding property tests for contract will be easily possible after
motsu
is refactored (see https://github.com/OpenZeppelin/stylus-test-helpers/pull/14/files#r1919897820)Resolves #458
PR Checklist