-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: ERC721Wrapper extension #461
base: main
Are you sure you want to change the base?
[Feature]: ERC721Wrapper extension #461
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
#[storage] | ||
pub struct Erc721Wrapper { | ||
/// Erc721 contract storage. | ||
pub _underlying: Erc721, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bidzyyys What should the type of _underlying
be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably be using pub underlying: Address
(no underscore), as this is an external contract, and Stylus currently has no way to represent them as part of structs.
You'll then also probably need to define a local sol interface, like in VestingWallet.
Hey @programskillforverification! |
I am going to finish this implementation and commit immediately once my vocation end up. |
Oh, okay, enjoy your time-off! |
Resolves #359
PR Checklist