Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Differential Tests for Functions in _merkle.rs_ #502

Open
1 task done
0xNeshi opened this issue Jan 21, 2025 · 0 comments
Open
1 task done

[Feature]: Add Differential Tests for Functions in _merkle.rs_ #502

0xNeshi opened this issue Jan 21, 2025 · 0 comments
Labels
effort: medium Default level of effort. priority: 0 Nice-to-have. Willing to ship without this. type: test Changes to the testing suite.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 21, 2025

What is the feature you would like to see?

See how Solidity's Foundry defines differential testing.

Differential tests would compare the results of our merkle verification implementation against some third-party implementation. This would help pinpoint any latent issues, bugs etc.

One possible candidate for this is rs-merkle, but we can search for other implementations if they're more robust/well-known

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added effort: medium Default level of effort. priority: 0 Nice-to-have. Willing to ship without this. type: test Changes to the testing suite. labels Jan 21, 2025
@0xNeshi 0xNeshi mentioned this issue Jan 21, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 0 Nice-to-have. Willing to ship without this. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xNeshi