Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Defender getDeployApprovalProcess and getUpgradeApprovalProcess #934

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Add Defender getDeployApprovalProcess and getUpgradeApprovalProcess #934

merged 4 commits into from
Dec 4, 2023

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Dec 4, 2023 •
edited
Loading

  • Add getDeployApprovalProcess and getUpgradeApprovalProcess
  • Deprecate getDefaultApprovalProcess (equivalent to getUpgradeApprovalProcess)

Fixes #933

@ericglau ericglau changed the title Add getDeployApprovalProcess and getUpgradeApprovalProcess Add Defender getDeployApprovalProcess and getUpgradeApprovalProcess Dec 4, 2023
@ericglau ericglau requested a review from a team December 4, 2023 20:10
MCarlomagno
MCarlomagno approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@MCarlomagno MCarlomagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/plugin-hardhat/src/defender/get-approval-process.ts Show resolved Hide resolved
@ericglau ericglau removed the request for review from a team December 4, 2023 21:22
@ericglau ericglau enabled auto-merge (squash) December 4, 2023 21:58
@ericglau ericglau merged commit 8327d6e into OpenZeppelin:master Dec 4, 2023
9 checks passed
@ericglau ericglau deleted the getDeployApprovalProcess branch December 4, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCarlomagno MCarlomagno MCarlomagno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defender: Support getting separate deploy and upgrade approval processes
2 participants
@ericglau @MCarlomagno