Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default number of retries, lower backoff factor #539

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Use default number of retries, lower backoff factor #539

merged 3 commits into from
Mar 15, 2022

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Mar 15, 2022 •
edited
Loading

Fixes #537

Change validations lock settings to have more retries and minimize unnecessary waits between retries:

  • settings: retries 10, minimum timeout 50 ms, exponential backoff factor 1.3
  • (previously was retries 3, minimum timeout 1000 ms, exponential backoff factor 2)

@ericglau ericglau requested a review from frangio March 15, 2022 15:41
@ericglau ericglau merged commit e914ea3 into OpenZeppelin:master Mar 15, 2022
@ericglau ericglau deleted the 537 branch March 15, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code ELOCKED during compile if importing in config file
2 participants
@ericglau @frangio