Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade web3 dependency to v4 in defender sdk #601

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix: upgrade web3 dependency to v4 in defender sdk #601

merged 3 commits into from
Oct 25, 2024

Conversation

MCarlomagno
Copy link
Member

Summary

Upgraded web3 js version from v1 to v4.

Adapted provider API to support EIP-1193

Testing Process

  • run relayer-web3-provider example
  • run unit tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d3d2012

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Oct 24, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, eval, network +47 8.96 MB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] Transitive: environment, eval +34 6.76 MB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] Transitive: environment, eval, network +59 15.8 MB luu-alex

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

tirumerla
tirumerla approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@tirumerla tirumerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks. Once we release this sdk version, we can update the backend version for action layer

zeljkoX
zeljkoX reviewed Oct 24, 2024
View reviewed changes
packages/relay-signer/src/web3/query.ts Outdated
)
.catch((err) => callback(err, undefined));
public async request<T>(payload: JsonRpcRequest<string[]>): Promise<JsonRpcResponseWithResult<T>> {
const toJsonRpcResponse = (result: any): JsonRpcResponseWithResult<T> => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be utility fn and not nested one

zeljkoX
zeljkoX reviewed Oct 24, 2024
View reviewed changes
packages/relay-signer/src/web3/sender.ts Outdated
@@ -30,17 +35,18 @@ export type DefenderRelaySenderOptions = Partial<{
maxPriorityFeePerGas: BigUInt;
speed: Speed;
validForSeconds: number;
authConfig: AuthConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need authConfig here? used for logic from web3 module?

Copy link
Member Author

@MCarlomagno MCarlomagno Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it's a leftover

zeljkoX
zeljkoX approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@zeljkoX zeljkoX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@MCarlomagno MCarlomagno merged commit 1a78fad into main Oct 25, 2024
9 checks passed
@MCarlomagno MCarlomagno deleted the plat-5505-upgrade-web3-dependency-to-v4-in-defender-sdk branch October 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeljkoX zeljkoX zeljkoX approved these changes

@tirumerla tirumerla tirumerla approved these changes

@collins-w collins-w Awaiting requested review from collins-w collins-w is a code owner

@CoveMB CoveMB Awaiting requested review from CoveMB CoveMB is a code owner

@dylankilkenny dylankilkenny Awaiting requested review from dylankilkenny dylankilkenny is a code owner

@emnul emnul Awaiting requested review from emnul emnul is a code owner

@shahnami shahnami Awaiting requested review from shahnami shahnami is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCarlomagno @zeljkoX @tirumerla