Feat/init refactor #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why all the changes in |
dblencowe
force-pushed
the
feat/init-refactor
branch
from
bf8d0ca
to
1fca2e0
Compare
Awful Git skills after having a mare with the Pipelines. Sorry! |
No worries 👍 |
dblencowe
force-pushed
the
feat/init-refactor
branch
from
1fca2e0
to
5208723
Compare
dblencowe
force-pushed
the
feat/init-refactor
branch
from
5208723
to
4674695
Compare
builderjer
reviewed
Jan 25, 2024
There was a problem hiding this comment.
This works when downloading from a tz file but fails to load when pointed to an onyx file.
2024-01-25 06:52:24.805 - audio - ovos_tts_plugin_piper:download_model:335 - INFO - downloading piper model: https://huggingface.co/rhasspy/piper-voices/blob/v1.0.0/en/en_GB/vctk/medium/en_GB-vctk-medium.onnx
2024-01-25 06:52:25.661 - audio - ovos_plugin_manager.tts:create:215 - ERROR - The TTS plugin "ovos-tts-plugin-piper" could not be loaded.
Available modules: ovos-tts-plugin-piper,ovos-tts-plugin-dummy,ovos-tts-plugin-server,ovos-tts-plugin-mimic3-server,ovos-tts-plugin-mimic
Traceback (most recent call last):
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_plugin_manager/tts.py", line 206, in create
tts = clazz(lang=None, # explicitly read lang from config
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 267, in __init__
self.get_model(voice=self.voice)
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 317, in get_model
engine = self.load_model_directory(xdg_p)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 355, in load_model_directory
config_dict = json.load(config_file)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2024-01-25 06:52:25.665 - audio - ovos_audio.service:__init__:93 - ERROR - Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
File "/home/ovos/ovos-src/ovos-audio/ovos_audio/service.py", line 90, in __init__
self._maybe_reload_tts()
File "/home/ovos/ovos-src/ovos-audio/ovos_audio/service.py", line 318, in _maybe_reload_tts
self.tts = TTSFactory.create(config)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/ovos-src/ovos-audio/ovos_audio/tts.py", line 9, in create
return OVOSTTSFactory.create(config)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_plugin_manager/tts.py", line 206, in create
tts = clazz(lang=None, # explicitly read lang from config
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 267, in __init__
self.get_model(voice=self.voice)
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 317, in get_model
engine = self.load_model_directory(xdg_p)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/ovos/venv-ovos/lib/python3.11/site-packages/ovos_tts_plugin_piper/__init__.py", line 355, in load_model_directory
config_dict = json.load(config_file)
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 293, in load
return loads(fp.read(),
^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/__init__.py", line 346, in loads
return _default_decoder.decode(s)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2024-01-25 06:52:25.675 - audio - ovos_audio.service:on_error:44 - ERROR - Audio service failed to launch (Expecting value: line 1 column 1 (char 0)).
Tested with multiple voices
dblencowe
force-pushed
the
feat/init-refactor
branch
2 times, most recently
from
b7ef5cd
to
64723ac
Compare
dblencowe
force-pushed
the
feat/init-refactor
branch
from
64723ac
to
30ce12c
Compare
goldyfruit
reviewed
Jan 30, 2024
requirements.txt
Outdated
| @@ -1,2 +1,3 @@ | |||
| ovos-plugin-manager>=0.0.5 | |||
| piper-tts==1.2.0 | |||
| piper-tts==1.1.0 | |||
| onnxruntime==1.16.3 | |||
There was a problem hiding this comment.
onnxruntime is already a dependency of piper-tts; https://github.com/rhasspy/piper/blob/master/src/python_run/requirements.txt#L2
There was a problem hiding this comment.
I thought that should be the case, but installs within the Neon docker container were failing as that dependency wasn't installed
goldyfruit
reviewed
Jan 30, 2024
dblencowe
force-pushed
the
feat/init-refactor
branch
from
30ce12c
to
d24fe77
Compare
I'll look at this; I'm using alba-medium (lookup URL from the list) which has downloaded and deployed fine. |
dblencowe
force-pushed
the
feat/init-refactor
branch
from
d24fe77
to
88fcbfe
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
dblencowe
force-pushed
the
feat/init-refactor
branch
2 times, most recently
from
699757b
to
3819cd8
Compare
mikejgray
suggested changes
Jun 7, 2024
There was a problem hiding this comment.
This worked fine with alan-low on a machine where I already had the model downloaded, but failed with the same error that @builderjer had when trying to use ryan-high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on my Mk2 with the alba-medium voice
Can be tested with