WIP: fix: fixes confict between piper-tts versions #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblencowe
force-pushed
the
fix/piper-phonemize-dependency
branch
from
cfdebd7
to
9fee33b
Compare
|
what conflict is this fixing exactly? |
dblencowe
force-pushed
the
fix/piper-phonemize-dependency
branch
from
9fee33b
to
8dc3075
Compare
If I'm understanding the error that the builds are currently throwing (here), piper-tts >= 1.2.0 depends on a version of a library that isn't available on versions of Python below 3.9. If I've understood that correctly, the solution is to either always install piper 1.2.0, or stop testing on python versions below 3.9? Happy to update if there's a better way! |
|
ok, merging this one so we have a last release published that works on older pythons, then ill merge the other one dropping compat for py < 3.9, those users will have to use an older plugin version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.