Skip to content

Commit

Permalink
Minor improvements and enforce some standards
Browse files Browse the repository at this point in the history
Command '[' uses '-n' by default:
* Never use '[ -n "$example" ]'
* Always use '[ "$example" ]'
This improves readabiity.

Use only '-e' to test for file existence.

Try to use simple tests, not 'not not X' (double negative) tests.
Example:
* [ "$EASYRSA_RAND_SERIAL != "no" ] = Replace with ' = "yes" '

Use 'shift' cleanly, immediately after assignment.

Improve/correct comments and user messages.

Signed-off-by: Richard T Bonhomme <[email protected]>
  • Loading branch information
TinCanTech committed May 20, 2022
1 parent deffb7e commit 1d22773
Showing 1 changed file with 81 additions and 87 deletions.
Loading

0 comments on commit 1d22773

Please sign in to comment.