Codechange: Remove using namespace std;
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
force-pushed
the
remove-using-std
branch
from
9f682cb to
e3d496f
Compare
Reference `std::` explicitly where it is used.
PeterN
force-pushed
the
remove-using-std
branch
from
e3d496f to
afee25c
Compare
glx22
reviewed
Sep 4, 2024
| @@ -92,12 +91,12 @@ char FD takes the same type of parameter as r, but adds that value to the | |||
| char FE as above | |||
| char C0 means to insert a linebreak (as if encountering C1..C4) but without | |||
| reading any bytes | |||
| A backslash is used to escape nulls that are not end-of-string characters | |||
| A backslash is used to escape nulls that are not end-of-std::string characters | |||
There was a problem hiding this comment.
Suggested change
| A backslash is used to escape nulls that are not end-of-std::string characters | |
| A backslash is used to escape nulls that are not end-of-string characters |
| * characters as bytes and construct a host endian ordered integer. | ||
| * Consequently, there is no need to swap endian for the read data; it | ||
| * characters as bytes and construct a host endian ordered integer. | ||
| * Consequently, there is no need to std::swap endian for the read data; it |
There was a problem hiding this comment.
Suggested change
| * Consequently, there is no need to std::swap endian for the read data; it | |
| * Consequently, there is no need to swap endian for the read data; it |
| // But I can't, so I have to manually generate the string instead. | ||
| void Act5CountWarn(const vector<int>&sizes){ | ||
| string str = mysprintf("%S",ACT5_SIZE, sizes[1], sizes[1]); | ||
| // But I can't, so I have to manually generate the std::string instead. |
There was a problem hiding this comment.
Suggested change
| // But I can't, so I have to manually generate the std::string instead. | |
| // But I can't, so I have to manually generate the string instead. |
| @@ -208,9 +207,9 @@ static const char _datTextIDs[]="\x04\x09" | |||
| "\x08\x01\x6C\x00\x38\x00\x43\x00\x44\x00\x00\x00\x06\x00\x00\x00" | |||
| //-C000- -D000- -E000- -F000- | |||
| "\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF\x4D\x00\x00\x00\x00\x00\x9B\x01" | |||
| // Number of special string ID ranges: | |||
| // Number of special std::string ID ranges: | |||
There was a problem hiding this comment.
Suggested change
| // Number of special std::string ID ranges: | |
| // Number of special string ID ranges: |
| "\x03" | ||
| // High bytes of special string IDs: | ||
| // High bytes of special std::string IDs: |
There was a problem hiding this comment.
Suggested change
| // High bytes of special std::string IDs: | |
| // High bytes of special string IDs: |
| @@ -460,7 +459,7 @@ NDF_END | |||
| #define DWORD 0x04 | |||
|
|
|||
| /* Formatting */ | |||
| #define QUOTED 0x10 /* Quoted string */ | |||
| #define QUOTED 0x10 /* Quoted std::string */ | |||
There was a problem hiding this comment.
Suggested change
| #define QUOTED 0x10 /* Quoted std::string */ | |
| #define QUOTED 0x10 /* Quoted string */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using namespace std;is bad practice, so don't.Reference
std::explicitly where it is used.