Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/828 - Workspace and repositories search and filter refactor #848

Merged
merged 8 commits into from
Dec 11, 2023

Conversation

D-GopalKrishna
Copy link
Contributor

@D-GopalKrishna D-GopalKrishna commented Dec 11, 2023

Issue related - #828

Task description

Implementation for the search and filter by tags do the following:

  1. First - Search the text in the search bar → This returns the list of workspaces/repos that have - either one or all - of the titles/summary/tags associated with them.
  2. Then, search for the tags that are set from the filters. From the result in (1) above, we return only the ones that have the tags selected from here (2).

Tags are now searched from the search bar - for both Repositories and Workspace - if they match any tags. This implementation is now in BE. And has been removed from Workspace FE (where it was added to the tags argument to pass to BE).

After this implementation:

  • The search and tags field works the same for both workspace and repos.
  • Also, the tag bug is removed now = on each text stroke tag gets added to the tags filter.
  • Repositories default per_page changed to 24 as well.

@D-GopalKrishna D-GopalKrishna marked this pull request as draft December 11, 2023 07:09
@D-GopalKrishna D-GopalKrishna marked this pull request as ready for review December 11, 2023 07:16
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @D-GopalKrishna!

@filippomc filippomc merged commit 815e22c into develop Dec 11, 2023
3 checks passed
@filippomc filippomc deleted the feature/828 branch December 11, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants