Adding new "Choose Profile" context menu to Project Files #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… easy to edit using your source file width+height+FPS profile. Avoid error message prompts when importing multiple files. Large refactor of how profile switching happens (moving to UpdateManger - so it will support undo/redo system). Add new profile() method to File Query class, to make it easy to generate/find a profile object for any File object.
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/windows/models/files_model.py
Did you find this useful? React with a 👍 or 👎 |
…e, and Delete custom profiles. Updated translations (new strings). Modified "Choose Profile" to apply a new profile, even if it's already applied (i.e. might have been edited now). Added new methods for inserting / updating / removing rows from the Profile model / view. Fixed small bug on the Export screen, to restore start/end frame correctly.
… to use the C++/Swig operator
…ted, so it can support undo/redo.
…Delete) options - to the user guide documentation.
…en adding a new custom profile and the context menu not updating correctly. Also, fixed the Profile comparison to use "is" since we just modified the Swig bindings for Profile equality operators.
…ch is currently used or the default project (in settings). Also validating custom profile has a unique description. Adding icons to Profile context menu. Added a new "Set as Default Profile" context menu option. Updated translations.
…how the "Create Profile" title.
… allow for editing a profile)
… selection when calling self.select_profile()
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new "Choose Profile" context menu to Project Files, to make it easy to edit using your source file width+height+FPS profile. Large refactor of how profile switching happens (moving to UpdateManger - so it will support undo/redo system). Add new profile() method to File Query class, to make it easy to generate/find a profile object for any File object.
Plus... avoid error message prompts when importing multiple files.