Theme Manager refactor (prevent freezing on Windows) #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve thread safety with lock - Keep 1 reference to manager - Remove all imports the manager (except 1) - Added logging if manager is not available, or themes are not found - This fixes a freeze in Windows on some systems during the launch of OpenShot, related to oleaut32.dll.
…lette. To prevent a freeze on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the ThemeManager, making it more thread-safe and less likely to freeze certain versions of Windows. This limits the # of times ThemeManager is imported, and maintains a single reference to the manager instance. It also removes ThemeManager access from the video widget paint method, which was directly responsible for the crash / freeze in certain versions of Windows.
The freeze would manifest itself as an issue with
oleaut32.dllin a debugger, which was the last line logged when the freeze would occur. While I never fully found the root cause of the freeze, removing ThemeManager from the video preview widget paint method seems to resolved the issue for testers.Closes #5549