-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Tracker & Object Detector Effects (Refactor, Bug-Fixes, Enhancements) #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eginning of the clip), and then jumping the preview to the first frame.
jonoomph
changed the title
Improving Tracker Effect Region Selection
Improving Tracker & Object Detector Effects (Faster Drawing, Corner Radius, and Invalid Region warning)
Feb 23, 2024
jonoomph
changed the title
Improving Tracker & Object Detector Effects (Faster Drawing, Corner Radius, and Invalid Region warning)
Improving Tracker Effect: Invalid Region Warning
Feb 23, 2024
…ct Detector effect)
…lip has a parent property set.
…lear class_filter in the Object Detector effect)
… Object detector selected objects. This was breaking due to the QIcon being NULL. Also, display the actual class name and object id for Object Detector selected objects choice menu.
… to tracker effects: Use clip->Parent to attach clips to tracked objects now.
… sub-divide into smaller lists (if needed). Also, change "Detected Objects" to "Tracked Objects" to be consistent between Parent and Selected Index menus.
…classes on the ObjectDetection effect.
…2 menus to appear or options to be missing.
… on a Tracked object. Improve documentation to notate new properties and read-only properties. Prevent a crash on video_widget.py if a load_json fails on the timeline.
…upport fixed alpha and display_box_text properties.
…) to utilize the Parent property of the clip instead
…to be on a higher track to be visible.
jonoomph
changed the title
Improving Tracker Effect: Invalid Region Warning
Improving Tracker & Object Detector Effects: Refactor, Bug-Fixes, Enhancements, etc...
Mar 26, 2024
jonoomph
changed the title
Improving Tracker & Object Detector Effects: Refactor, Bug-Fixes, Enhancements, etc...
Improved Tracker & Object Detector Effects (Refactor, Bug-Fixes, Enhancements)
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: OpenShot/libopenshot#950
Improvements:
Prompting user if Tracker effect region is invalid (i.e. not at the beginning of the clip), and then jumping the preview to the first frame. Otherwise, if a user chooses a region further into a clip, the Tracker can often fail to ever correctly track this region, since it always begins tracking on the 1st frame of the clip.
Improved Selected Object menu (Object Detection Effect)
New Parent Badge (for any clip which has a parent set):
Refactor Object Detector with QPainter (support for corner radius, faster drawing performance)
Refactor Tracker with QPainter (support for corner radius, faster drawing performance)