Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Tracker & Object Detector Effects (Refactor, Bug-Fixes, Enhancements) #5430

Merged
merged 21 commits into from
Mar 26, 2024

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Feb 19, 2024

Related PR: OpenShot/libopenshot#950

Improvements:

  • Fixed timeline tooltips on clip titles, effects and parent badges (bootstrap js update)
  • Disable "Process Effect" button after clicked
  • Fixed right click menu on "Selected Object" property editor (it was broken). Added "class_name: object id" as format.
  • Added ability to clear class_filter (on Object Detector effect)
  • Removing child_clip_id property, replacing with parent property for the actual child clips (I.e. parent any clip on a tracked object I'd)
  • Fix sorting of tracked object properties in the Property Editor
  • Added lots of new documentation for Effects, including Tracker & Object Detector effects. New docs on Parenting also include.
  • Large refactor of context menus in OpenShot (when they contain more than 20 items of sub-items). Nested menus now contain a range of items (I.e. 1-20, 21-40, etc...). Applied this format to all Property Editor context menus used in OpenShot.
  • Added 'class_filter' context menus, to choose between any visible tracked object classes (I.e. car, truck, etc...)
  • Fixed undo/redo issues related to effect property's being updated. For example, some effect updates (or tracked object property updates) would not undo correctly.
  • No longer show context menus for read-only properties
  • Migrate old *.osp projects that include Tracker or Object Detector effects, to fix alpha values, move child_clip_id to the parent property, etc...
  • Bump version of OpenShot to 3.1.1-dev

Prompting user if Tracker effect region is invalid (i.e. not at the beginning of the clip), and then jumping the preview to the first frame. Otherwise, if a user chooses a region further into a clip, the Tracker can often fail to ever correctly track this region, since it always begins tracking on the 1st frame of the clip.

OpenShot-Choose-Valid-Region

Improved Selected Object menu (Object Detection Effect)
OpenShot-Object-Selector-Menu

New Parent Badge (for any clip which has a parent set):
OpenShot-Parent-Badge


Refactor Object Detector with QPainter (support for corner radius, faster drawing performance)
OpenShot-Object-Detector-Radius

Refactor Tracker with QPainter (support for corner radius, faster drawing performance)
OpenShot-Tracker-Radius

…eginning of the clip), and then jumping the preview to the first frame.
@jonoomph jonoomph changed the title Improving Tracker Effect Region Selection Improving Tracker & Object Detector Effects (Faster Drawing, Corner Radius, and Invalid Region warning) Feb 23, 2024
@jonoomph jonoomph changed the title Improving Tracker & Object Detector Effects (Faster Drawing, Corner Radius, and Invalid Region warning) Improving Tracker Effect: Invalid Region Warning Feb 23, 2024
…lear class_filter in the Object Detector effect)
… Object detector selected objects. This was breaking due to the QIcon being NULL. Also, display the actual class name and object id for Object Detector selected objects choice menu.
… to tracker effects: Use clip->Parent to attach clips to tracked objects now.
… sub-divide into smaller lists (if needed). Also, change "Detected Objects" to "Tracked Objects" to be consistent between Parent and Selected Index menus.
… on a Tracked object. Improve documentation to notate new properties and read-only properties. Prevent a crash on video_widget.py if a load_json fails on the timeline.
…upport fixed alpha and display_box_text properties.
…) to utilize the Parent property of the clip instead
@jonoomph jonoomph changed the title Improving Tracker Effect: Invalid Region Warning Improving Tracker & Object Detector Effects: Refactor, Bug-Fixes, Enhancements, etc... Mar 26, 2024
@jonoomph jonoomph changed the title Improving Tracker & Object Detector Effects: Refactor, Bug-Fixes, Enhancements, etc... Improved Tracker & Object Detector Effects (Refactor, Bug-Fixes, Enhancements) Mar 26, 2024
@jonoomph jonoomph merged commit ab16c9d into develop Mar 26, 2024
9 checks passed
@jonoomph jonoomph deleted the invalid-tracker-region branch March 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant