Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Tracker & Object Detector Effects (Faster Drawing, Corner Radius, New Style) #950

Merged
merged 15 commits into from
Mar 26, 2024

Commits on Feb 22, 2024

  1. Refactor of Tracker effect and TrackedObjectBBox:

    - Draw Tracker boxes using QPainter and support corner radius (and faster drawing performance by drawing directly on the frame)
    - Draw child clips with correct aspect ratio
    - Adding "Yes/No" options for "Visible" and "Draw Box" Tracked Object Box keyframes
    - default to invisible background
    - default to 12 corner radius
    - default to 50% stroke alpha
    jonoomph committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3af6e1f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Refactor of ObjectDetection effect:

    - Draw bounding boxes using QPainter and support corner radius (and faster drawing performance by drawing directly on the frame)
    - Draw child clips with correct aspect ratio
    - Adding "Yes/No" option for "Draw Text"
    - default to fully opaque stroke
    jonoomph committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    98383fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4594cf8 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Configuration menu
    Copy the full SHA
    04ec023 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    a1f67a9 View commit details
    Browse the repository at this point in the history
  2. Refactor of clip caching, to prevent caching flattened images with pr…

    …evious layers, replace std::shared_ptr<openshot::Frame> with QSize for a few arguments to make it much more clear what is happening.
    jonoomph committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    15be792 View commit details
    Browse the repository at this point in the history
  3. Set range of background corner radius to 150.0 (which is essentially …

    …a circle in my testing). Also, ignoring case of class_filter on Object Detection effect.
    jonoomph committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8f3c324 View commit details
    Browse the repository at this point in the history
  4. Change Object Detector to display the class name: object id, instea…

    …d of the confidence score. This is way more useful, so you can find the object in the properties menu. Also, output the visible class names as well, so the property editor can display them in a context menu.
    jonoomph committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    f15c91d View commit details
    Browse the repository at this point in the history
  5. Removing "ChildClipId" property, no longer used for attaching clips t…

    …o tracker or object detection effects: Use clip->Parent to attach clips to tracked objects now.
    jonoomph committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    07e4458 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    698e6f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3351b52 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Fixing parentClipObject and parentTrackedObject transform, so the par…

    …ent clip can be scaled and moved without breaking the tracking. Also refactoring out unneeded complex code left over.
    jonoomph committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    620e894 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Fix race condition causing clip to clip parents not to work. Adding a…

    … late-bound check, to ensure we have attached the clip on first call.
    jonoomph committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8b47373 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Fixing aspect ratio of tracked objects, since the tracked object ofte…

    …n is of varying aspect ratios (since the parent clip and tracked object can change over time). Clips which are parented to tracked objects now respect the scale_type (i.e. best fit, stretch, etc...).
    jonoomph committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    ffb63f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Add new "Display All Boxes" Object Detector property, since it can be…

    … difficult to turn off each individual box. Made "visible" property read-only on Tracker & Object Detector effects. Improve Keyframe::SetJsonValue method to accept an object or a float.
    jonoomph committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5a0a6a6 View commit details
    Browse the repository at this point in the history