Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMScan devkit #88

Merged
merged 18 commits into from
Dec 26, 2024
Merged

MMScan devkit #88

merged 18 commits into from
Dec 26, 2024

Conversation

rbler1234
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Modification

Update the branch regarding MMScan.

Modification

  • MMScan data processing code.
  • Introduction and tutorial for MMScan.
  • MMScan's data loading and evaluation-related API code.
    (The model-related code will be uploaded subsequently.）

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@rbler1234 rbler1234 changed the title Mmscan devkit MMScan devkit Nov 18, 2024
mxh1999
mxh1999 requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@mxh1999 mxh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the structure is a little strange.
Maybe it would be better not to be a branch of embodiedscan

data_preparation/README.md Show resolved Hide resolved
data_preparation/process_all_scan.py Outdated Show resolved Hide resolved
data_preparation/process_all_scan.py Show resolved Hide resolved
data_preparation/process_all_scan.py Show resolved Hide resolved
data_preparation/utils/scannet_process.py Outdated Show resolved Hide resolved
mmscan/evaluator/metrics/box_metric.py Show resolved Hide resolved
mmscan/evaluator/vg_evaluation.py Outdated Show resolved Hide resolved
mmscan/evaluator/vg_evaluation.py Outdated Show resolved Hide resolved
mmscan/mmscan.py Outdated Show resolved Hide resolved
models/README.md Outdated Show resolved Hide resolved
@mxh1999 mxh1999 self-requested a review November 25, 2024 11:42
mxh1999
mxh1999 requested changes Nov 25, 2024
View reviewed changes
data_preparation/process_all_scan.py Outdated Show resolved Hide resolved
mmscan/evaluator/vg_evaluation.py Outdated Show resolved Hide resolved
mmscan/utils/lang_utils.py Show resolved Hide resolved
@mxh1999 mxh1999 self-requested a review November 27, 2024 11:15
mxh1999
mxh1999 reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@mxh1999 mxh1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code (excluding the third-party model) is ok

@mxh1999 mxh1999 requested a review from Tai-Wang November 27, 2024 11:22
@mxh1999
Copy link
Collaborator

mxh1999 commented Nov 29, 2024

@rbler1234 Don't modify this branch until it has been merged, you can create another branch for develop.

Tai-Wang
Tai-Wang reviewed Dec 13, 2024
View reviewed changes
data_preparation/README.md Outdated
4. Organize the file structure. You are recommanded to create a soft link to the raw data folder under `mmsan_data/embodiedscan-split/data`.

```
mmsan_data/embodiedscan-split/data/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, mmscan, please also fix other places

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the embodiedscan-split folder

Tai-Wang
Tai-Wang reviewed Dec 13, 2024
View reviewed changes
mmscan/__init__.py Outdated Show resolved Hide resolved
Tai-Wang
Tai-Wang reviewed Dec 17, 2024
View reviewed changes
data_preparation/process_all_scan.py
es_anno = {}


def mmengine_track_func(func):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary if using the 'mmengine' to run multi-process multi-parameter functions.

@Tai-Wang Tai-Wang merged commit cc3842a into OpenRobotLab:mmscan Dec 26, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-Wang Tai-Wang Tai-Wang left review comments

@mxh1999 mxh1999 mxh1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbler1234 @mxh1999 @Tai-Wang