Handle both invalid trigrams and uics as invalid op

[achrafmohye]

Closes #10116

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (9ddc06c) to head (6021ad9).
Report is 156 commits behind head on dev.

Files with missing lines	Patch %	Lines
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts	0.00%	16 Missing ⚠️
...nt/src/modules/pathfinding/hooks/usePathfinding.ts	0.00%	4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10471      +/-   ##
==========================================
+ Coverage   81.61%   81.85%   +0.24%     
==========================================
  Files        1067     1075       +8     
  Lines      105535   107173    +1638     
  Branches      727      728       +1     
==========================================
+ Hits        86128    87724    +1596     
- Misses      19366    19410      +44     
+ Partials       41       39       -2     

Flag	Coverage Δ
editoast	74.24% <ø> (+0.55%)	⬆️
front	89.38% <0.00%> (+0.08%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (+1.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Akctarus]

Tested, ty for this fix

[emersion]

Placeholder comment, just so that GitHub gets this PR off my TODO list :P

See the discussion above.

[emersion]

The new logic looks good!

It seems like the usePathfinding() hook has a similar bug: handleInvalidPathItems() there checks trigrams only. There is a TODO:

// TODO: we currently only handle invalid pathSteps with trigram. We will have to do it for trackOffset, opId and uic too.

Are you feeling up for adding a new commit to fix that bug and do something similar to the logic in this PR, or do you prefer to leave that for later?

[emersion]

Thanks, looks good!

(For next time: ideally the usePathFinding change should be in its own separate commit :P )