Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: review: add PR testing script #241

Merged
merged 1 commit into from
Oct 7, 2024
Merged

docs: review: add PR testing script #241

merged 1 commit into from
Oct 7, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

No description provided.

@EthanPERRUZZA EthanPERRUZZA mentioned this pull request Oct 1, 2024
Merged
bougue-pe
bougue-pe requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bougue-pe bougue-pe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 🇫🇷 comments deemed relevant should also be addressed in 🇬🇧

content/docs/guides/contribute/code-review.fr.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.fr.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.fr.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.fr.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.fr.md Outdated Show resolved Hide resolved
bougue-pe
bougue-pe approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@bougue-pe bougue-pe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little more (nitpicky) review.
OK for me anyway, let you decide to consider (part of) these comments then squash and merge.

content/docs/guides/contribute/code-review.en.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.en.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/code-review.en.md Outdated Show resolved Hide resolved
@EthanPERRUZZA
Copy link
Contributor Author

Thanks for the reviews ! :D

@bougue-pe bougue-pe self-requested a review October 3, 2024 14:11
@EthanPERRUZZA EthanPERRUZZA merged commit 47826a5 into master Oct 7, 2024
4 checks passed
@EthanPERRUZZA EthanPERRUZZA deleted the eth/pr-test-script branch October 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeCroise SergeCroise SergeCroise left review comments

@bougue-pe bougue-pe bougue-pe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanPERRUZZA @SergeCroise @bougue-pe