build: use rollup --failAfterWarnings #833
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got to a point where we've eliminated all build errors. We previously did not notice these because they only show up as warnings in CI, without making CI fail. Use rollup --failAfterWarnings so that CI fails when a build error is emitted. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/rollup-fail-with-warnings
branch
from
d929077 to
a5efed1
Compare
|
This is blocked by a cyclic dependency between ui-spacetimechart and ui-trackoccupancydiagram. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got to a point where we've eliminated all build errors. We
previously did not notice these because they only show up as
warnings in CI, without making CI fail.
Use rollup --failAfterWarnings so that CI fails when a build error
is emitted.
Depends on #832