Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access metadata: load properties and expose them #88

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

Tristramg
Copy link
Contributor

This pull request should be readable commit after commit (each language separately)

@Tristramg Tristramg requested a review from Castavo November 30, 2024 17:43
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with python, works very fine.

Don't know how to test wasm bindings, could you help me ?

The code looks clean, it's weird that the Properties type belongs to the builder module and not the lrs module, but that was there before, so it's okay I guess

Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
Signed-off-by: Tristram Gräbener <[email protected]>
@Tristramg
Copy link
Contributor Author

I moved out Properties to put it in the Lrs module

To test wasm, you could add some console.log in the demonstrator to be sure that we read the data. Maybe I should learn how to make a node script to avoid going through all the navigator stuff, but I’m not confident for that.

@Tristramg Tristramg self-assigned this Dec 2, 2024
@Tristramg Tristramg merged commit 7768591 into main Dec 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants