Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wall version of beta brick terrain edge #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fidwell
Copy link
Contributor

@fidwell fidwell commented Aug 2, 2024

Resolves #340. Created a new wall object that match the texture of the brick wall beta terrain edge.

image

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Aug 3, 2024

I'm a bit unsure if it would make sense to include the rock walls as there's no wall version of the final/RCT2 rock edge.

For the names i would just shorten them to "Brick Wall" and "Rock Wall" or even just "Wall" as the wall names in vanilla are pretty generic.

For the object ids should remain "official" as they were not a part of the rct1 beta, they're just official additions based on the beta assets.

@fidwell
Copy link
Contributor Author

fidwell commented Aug 3, 2024

I didn't even consider that some of the terrain edges don't have corresponding walls. I probably wouldn't have made the rock wall if I'd thought about it.

If anyone feels strongly about not having them, that's fine by me.

@tbarford
Copy link

tbarford commented Aug 4, 2024

Maybe add that wall texture as a scenery wall, too?

@deurklink
Copy link
Contributor

I think it would be really nice to have the other wall edge textures as scenery too

@Gymnasiast
Copy link
Member

I generally want to keep the brakes on adding too much extra content. Could you put forth your arguments for including these as official content?

@fidwell
Copy link
Contributor Author

fidwell commented Dec 22, 2024

Having the beta brick wall would create a nice parity with how the existing brick terrain edge has a wall that goes with it.

The rock wall doesn't fit as well and I don't have any strong arguments about keeping that one.

@karst
Copy link
Member

karst commented Jan 15, 2025

I could see the brick wall fit in with the default objects, I could see rock wall (as well as for the non-beta versions) be a non-essential official object.
@Gymnasiast good ideas for the object store, too?

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Jan 15, 2025

For what it's worth, the brick wall was the only one i mentioned on the issue that prompted this PR. #340.

@fidwell
Copy link
Contributor Author

fidwell commented Jan 15, 2025

I've rebased this PR and limited the change to just adding the brick wall.

@fidwell fidwell changed the title Add wall versions of beta terrain edges Add wall version of beta brick terrain edge Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scenery wall versions of beta brick edge
6 participants