-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should NOT be merged, but it works #187
Open
alexlib
wants to merge
37
commits into
OpenPTV:master
Choose a base branch
from
alexlib:refactor_fb
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So if we could start tracking without reading from files it means that we can prepare the buffer before tracking during the separate steps of the algorithm and then we need still to replace the fb_next and read_frame and so on by fb_load or something like this? or maybe all is not necessary - we like give tracker the prio from the previous chunk and let it run like for the first time every time, not continuosly and not membering anything backwards. so we are now will be limited to run tracking only to the size of the buffer itself. not a nice one. if we want to have 10 frames and track using our 4-step algorithm, then we have to create functions that are reading from some memory, fill and advance the buffer in these 10 frames.
…hing in C and failed. probably it was just me :)
Separate frame-buffer to a base class and child class.
release img later
and downloaded libtiff 4.010 https://download.osgeo.org/libtiff/
(base) MacBook-Pro:src alex$ ./main ../tests/testing_fodder/test_cavity/ 10000 10004 This program was called with "./main". Can't open ORI file: testing_fodder/cal/sym_cam1.tif.ori Can't open ORI file: testing_fodder/cal/sym_cam2.tif.ori Can't open ORI file: testing_fodder/cal/sym_cam3.tif.ori Can't open ORI file: testing_fodder/cal/sym_cam4.tif.ori Segmentation fault: 11
need to learn better C
file main.c runs but does not track anything
cannot find what's wrong now in the projection from 2D to 3D - results are aweful.
…ions, maybe only correspondences and path info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is only temporary, please DO NOT merge it. It violates the great work by @yosefm on the new buffer type with virtual functions.
But, I'm very happy to see that it works and tracks through
test_cavity
. It's somewhat ready to be a skeleton for the DLL for BlobRecorder.