Dynamic convergence #163
Open
Dynamic convergence #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the convergence to get first guess better than can be used in addpar modification
removed the check for target == found, not sure it's relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the name is probably confusing, sorry for that. The problem appears to happen with some of the "rough" calibrations, where the present number of iterations and convergence are not sufficient to find a solution for additional parameters. This is my poor attempt to make it a bit more robust, yet not immediately slow: we first increase slowly the number of iterations and hope that 500 will be sufficient, then we can increase the threshold for convergence and see if it's sufficient. Probably it's not very robust, as there are might be corner cases where this will still fail, but I do not have a better idea.