Api2: Fixes getProductUrl

[Hanmac]

Description (*)

This fixes REST API2 Product url to use the store parameter.

Related Pull Requests

• see OpenMage/magento-lts#<issue_number>

Fixed Issues (if relevant)

• fixes [Api2] [Catalog] Product URL returned by REST Api is wrong store #4510

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[github-actions]

Test Results

541 tests  ±0   533 ✅ ±0   3s ⏱️ ±0s
145 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bce2f88. ± Comparison against base commit fc9a8ca.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

Mhhh, cant reproduce atm ... my json-response has the correct frontend-url.

[Hanmac]

Use multiple stores with web/url/use_store enabled
Then the Guest Api doesn't use the Frontend Route
So it can't decide what the current store should be

then this line:

magento-lts/app/code/core/Mage/Catalog/Helper/Product.php

Line 62 in 488c021

return Mage::getModel('catalog/product')->load($product)->getProductUrl();

does load the product without store id set

[sreichel]

The fix is valid, but i still have no admin-url in response - its always a frontend-url.

• Use multiple stores with web/url/use_store enabled (thats default in sample data)
• enabled "add store code to url"

-> returns default store url (not admin)

After this fix i get the correct frontend-url.

[Hanmac]

What exactly is your REST url?
I tried https://myserver/api/rest/products/sku?store=5
when doing this, my current Store is 0

that's why i get admin as store name

[sreichel]

https://magento-lts.ddev.site/api/rest/products/ace000?store=0

https://magento-lts.ddev.site/default/aviator-sunglasses.html

https://magento-lts.ddev.site/api/rest/products/ace000?store=1

https://magento-lts.ddev.site/default/aviator-sunglasses.html

https://magento-lts.ddev.site/api/rest/products/ace000?store=2

https://magento-lts.ddev.site/french/aviator-sunglasses.html

https://magento-lts.ddev.site/api/rest/products/ace000?store=3

https://magento-lts.ddev.site/german/aviator-sunglasses.html

[Hanmac]

@sreichel you can try to debug it too, but for me, when getUrlModel is called, the StoreId of the Product is still null,
and then app says the current store is admin

magento-lts/app/code/core/Mage/Catalog/Model/Product.php

Lines 368 to 374 in 488c021

	public function getStoreId()
	{
	if ($this->hasData('store_id')) {
	return (int) $this->getData('store_id');
	}
	return Mage::app()->getStore()->getId();
	}

[sreichel]

Checked and everything is fine.

Please debug Mage_Api2_Model_Resource::_getStore().

[Hanmac]

Checked and everything is fine.

Please debug Mage_Api2_Model_Resource::_getStore().

like is said before, it doesn't matter. While the _getSore method is called and loads the store for the given parameter, it doesn't alter the default store.

So when this line later happens, it will create a new Product object with the store parameter set to null, and then it will fall back to the current store (which is admin for the api)

magento-lts/app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php

Line 121 in fc9a8ca

$productData['url'] = $productHelper->getProductUrl($product->getId());

[sreichel]

The fix is valid, but i still have no admin-url in response - its always a frontend-url.

You got me wrong. Your fix works - but for me the behavoir was different before the fix. I had no admin url,

[Hanmac]

@sreichel makes me wonder what does this $productHelper->getProductUrl does different for you than for me, that you get a different store.

Also for later, we might need to think about deprecating the getProductUrl from the Product Helper because it only causes problems in multi store if using product_id?

The only other place that uses Mage_Catalog_Helper_Product::getProductUrl is Mage_Catalog_Block_Seo_Sitemap_Product,
and the Sitemap uses the Product Item and not the Id