Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: removed js/jscolor #4458

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2025

Description (*)

jscolor.js is not used.

@sreichel sreichel modified the milestones: 20.12.0, 20.13.0 Jan 6, 2025
fballiano referenced this pull request in MahoCommerce/maho Jan 7, 2025
@sreichel sreichel added the JavaScript Relates to js/* label Jan 7, 2025
@addison74
Copy link
Contributor

In the past, someone else suggested deleting this file and I pointed out that it is used in extensions like MageWorx Advanced Product Options.

@sreichel
Copy link
Contributor Author

sreichel commented Jan 13, 2025

Should we really keep files that are not used?

  • you can still grab that files from a previous release
  • if requested often (i doubt) we can add a repo (please not)

With next composer-plugin update it is possible to add custom fiiles from NPM/unpkg.com.

Cou can add this to composer extra ...

        "openmage-unpkg-packages": {
            "@eastdesire/jscolor": {
                "version": "2.5.2",
                "source": "",
                "target": "js/jscolor",
                "files": [
                    "jscolor.js"
                ]
            }
        }

Note:

This is just an example. Current version of jscolor is 1.4.5. That's so old and not even avalaible at https://unpkg.com/ or https://www.npmjs.com.

Lets remove it. We can still help to update that extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup JavaScript Relates to js/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants