Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpUnit: updated and added tests #4454

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

PhpUnit: updated and added tests #4454

wants to merge 34 commits into from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2025

No description provided.

@sreichel
bumped version
ee90d05
@sreichel
updated tests
c21fe6b
@sreichel
Merge branch 'main' into phpunit-dates
61dd0f6 
# Conflicts:
#	tests/unit/Mage/Catalog/Model/Resource/Eav/AttributeTest.php
@sreichel sreichel marked this pull request as draft January 6, 2025 15:06
@sreichel sreichel added the chore label Jan 6, 2025
@sreichel sreichel added this to the 20.12.0 milestone Jan 6, 2025
@sreichel sreichel marked this pull request as ready for review January 6, 2025 22:10
@sreichel sreichel modified the milestones: 20.12.0, 20.13.0 Jan 6, 2025
@sreichel sreichel mentioned this pull request Jan 8, 2025
Draft
@sreichel sreichel dismissed stale reviews from addison74 and kiatng via 26c085f January 15, 2025 02:20
@github-actions github-actions bot added Component: Reports Relates to Mage_Reports composer Relates to composer.json ddev rector labels Jan 15, 2025
kiatng
kiatng previously approved these changes Jan 15, 2025
View reviewed changes
@sreichel sreichel marked this pull request as draft January 15, 2025 02:32
@sreichel sreichel mentioned this pull request Jan 15, 2025
Open
@github-actions github-actions bot added the Component: Index Relates to Mage_Index label Jan 15, 2025
@sreichel sreichel mentioned this pull request Jan 15, 2025
Closed
@sreichel sreichel marked this pull request as ready for review January 15, 2025 23:03
@sreichel sreichel requested review from addison74 and kiatng January 15, 2025 23:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel requested a review from Hanmac January 18, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour Awaiting requested review from colinmollenhour

@addison74 addison74 Awaiting requested review from addison74

@kiatng kiatng Awaiting requested review from kiatng

@Hanmac Hanmac Awaiting requested review from Hanmac

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
chore Component: Index Relates to Mage_Index Component: Reports Relates to Mage_Reports composer Relates to composer.json ddev php-cs-fixer phpstan phpunit rector
Projects
None yet
Milestone
20.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @kiatng @addison74