Install TinyMCE 7.5 via composer

[sreichel]

Description (*)

I've updated the copy-plugin to work if you install OpenMage as composer dependency.

Related Pull Requests

• see Updated TinyMCE to 6.8 via composer 🚀 #3658
• see Revert "Updated TinyMCE to 6.8 via composer 🚀" #3705
• closes Tinymce 69 #4403

Update

• moved block classes from Adminhtml/Cms to Cms/Adminhtml (and deprecated old ones)

Todo

• for another PR ... add another config option to always use editor
• for another PR ... disable editor if TinyMce is not installed

[addison74]

Very good idea, but @fballiano, @empiricompany and I worked on a custom version for TinyMCE which is now available in version 20. Installing TinyMCE with Composer will benefit the version we have already in OpenMage or do we need some patches for Composer?

[sreichel]

@addison74 i have seen no changes made to TinyMCE itself, so the files are the same as currently used.

[sreichel]

@addison74 note: when you install OM as composer dependency, you have to install that plugin too.

[sreichel]

Waiting for final response from TinyMCE, but it looks like we CAN use v7 ...

Maybe some is really familiar with licensing ... answer so far.

GPL Version 2 or later grants users the freedom to use, modify, and distribute software, as long as any derivative works are also distributed under the same license and the source code is made available to recipients.

In simplified terms, this means that when distributing an app containing GPL licensed code, the whole app will inherit the GPL license and the source code must be made available to the community. This is usually a no-go in a commercial use case.

OM is no derivative work from TinyMCE, so we dont have to put it under GPL itself.

We use it in a non-commercial project. We follow (inherit?) GPL and all code is available to the community.

From my understanding ... if someone uses a OM-fork as commercial product, HE had to put it under GPL - not we.

Waiting for response, but v7 seems to work ...

[addison74]

I didn't think to contact them, but what you say there seems to make sense. If we get an official answer that we can use version 7, that would be wonderful. If I'm not mistaken, Magento 2 is still at version 5.

[addison74]

@sreichel - Did you get any reply from TinyMCE regarding using v7 in OpenMage?

[sreichel]

@addison74 i dont know ... my email-account is currently locked and seems not so easy to get it unlocked.

With this PR we are prepared for a possible 6.8.5 release that will come "for sure" (6.8 is supported till next year).

[kiatng]

I'm not sure how to test. What I did in DDEV:

1. [bash] gb pr checkout 4113
2. [bash] composer upgrade
3. [browser] OpenMage admin > CMS > Pages > select any page > Contents > Show Editor > Help > Version

I get: "You are using TinyMCE 6.8.4" but I expect 7.5. What am I missing?

[edit] My browser was loading the TinyMCE from cache. When I refreshed with ctrl-F5, and click Show/Hide Editor button, developer console error:

GET https://openmage.ddev.site/js/tinymce/tinymce.min.js net::ERR_ABORTED 404 (Not Found)

26f643ca40eef9198d0cc35c61fb485c/:68 
        
        
       GET https://openmage.ddev.site/js/tinymce/tinymce.min.js net::ERR_ABORTED 404 (Not Found)
setup.js:218 Uncaught ReferenceError: tinymce is not defined
    at klass.toggle (setup.js:218:9)
    at HTMLButtonElement.<anonymous> (prototype.js:7273:15)
toggle @ setup.js:218
(anonymous) @ prototype.js:7273

[addison74]

@kiatng - How did you install OpenMage in the directory configured to use DDEV?

[sreichel]

Ahhh ... i forgot to commit some changes to composer-plugin.

OpenMage/composer-plugin@43369eb

[sreichel]

Sorry for missing commit.

Tested again.

Github install (checkout repo + composer install)

Composer install with custom magento-root-dir (as nin config above)

If it still shows v6.8 please run composer install -v to show tinymce version or -vv to see copy paths.

[sreichel]

@kiatng - How did you install OpenMage in the directory configured to use DDEV?

If you want to install with ddev command, please check this code ... #4407

To make DDEV commands available for composer installs, they move to a ddev-addon. Later.

[sreichel]

... conflicts fixed ... grrr

[sreichel]

We did it. 👍