Only process subsystems with rdma transport #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-rdma subsystem is encountered, dss_host.py fails silently. As a result the nkv conf json files fail to be generated. As a work-around, only process subsystems with RDMA transport. This is the same "hack" I put in to place in the `subnet_drive_map` function. This `mountpt_to_nqn_addr_map` is basically an identical function, but it is called with gen2 config. This needs to be refactored ASAP. I see at least one other spot where this blind regex is executed (`discover_dist` function), but I don't think this is live code. Again this needs to be refactored and cleaned up.
|
aaronlee121
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-rdma subsystem is encountered, dss_host.py fails silently. As a result the nkv conf json files fail to be generated. As a work-around, only process subsystems with RDMA transport.
This is the same "hack" I put in to place in the
subnet_drive_mapfunction.This
mountpt_to_nqn_addr_mapis basically an identical function, but it is called with gen2 config.This needs to be refactored ASAP.
I see at least one other spot where this blind regex is executed (
discover_distfunction), but I don't think this is live code. Again this needs to be refactored and cleaned up.