Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manufacturer updates #287

Merged

Conversation

peternewman
Copy link
Member

No description provided.

peternewman and others added 20 commits April 7, 2021 21:27
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
@FloEdelmann
Copy link
Member

@peternewman Is there any chance to get this merged soon?

We have manufacturer "Fiilex" in the Open Fixture Library (https://open-fixture-library.org/fiilex), which has RDM ID 24868/0x6124. It is also listed here: https://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php

But it is not included in the RDM app: http://rdm.openlighting.org/manufacturer/display?manufacturer=24868

@peternewman peternewman merged commit 721d5b2 into OpenLightingProject:master Oct 10, 2021
@peternewman
Copy link
Member Author

@peternewman Is there any chance to get this merged soon?

It's merged now, although until #206 gets in (and they moved the goalposts when I was almost there), I don't have a particularly easy way to deploy it currently unfortunately. 😢

We have manufacturer "Fiilex" in the Open Fixture Library (https://open-fixture-library.org/fiilex), which has RDM ID 24868/0x6124. It is also listed here: https://tsp.esta.org/tsp/working_groups/CP/mfctrIDs.php

But it is not included in the RDM app: http://rdm.openlighting.org/manufacturer/display?manufacturer=24868

I think I could manually insert this manufacturer if that helps? Are they the only one you're missing currently?

@FloEdelmann
Copy link
Member

Yes, that's the only missing manufacturer so far. If adding manually is possible, that would help a lot. Then we have one less failing link 😅

@peternewman
Copy link
Member Author

I think that's there now @FloEdelmann . After I changed the URL from blank to null and flushed the cache.

Do you want to check if it's sorted your issue?

@FloEdelmann
Copy link
Member

It did, thank you! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants