Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture prolights/arcled130tri #4566

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture prolights/arcled130tri

Thank you @bline54!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 17, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ prolights / arcled130tri: d-light / attributes-correctness
  • ✔️ prolights/arcled130tri-4ch.xml
  • ✔️ prolights/arcled130tri-3ch.xml
✔️ prolights / arcled130tri: dmxcontrol3 / channel-numbers
  • ✔️ prolights-arcled130tri-4ch.xml
  • ✔️ prolights-arcled130tri-3ch.xml
✔️ prolights / arcled130tri: dragonframe / json-schema-conformity
  • ✔️ prolights/arcled130tri.json
  • ✔️ manufacturers.json
✔️ prolights / arcled130tri: millumin / json-schema-conformity
  • ✔️ prolights/arcled130tri.json
✔️ prolights / arcled130tri: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Prolights-ArcLed130Tri.qxf
✔️ prolights / arcled130tri: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Prolights-ArcLed130Tri.qxf

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, as far as it goes, but the fixture also has 10ch, DRGBS(tore?), and HSV modes which aren't included in this file yet.

Fortunately the documentation looks really good so it shouldn't be difficult to add them.

},
"links": {
"manual": [
"https://www.prolights.it/en/product/ARCLED7314TRI#:~:text=Arcled7314tri_USER_MANUAL_ITEN.pdf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.prolights.it/en/product/ARCLED7314TRI#:~:text=Arcled7314tri_USER_MANUAL_ITEN.pdf"
"https://support.musiclights.it/ajx.php?usst=1&docs=9229&ID_USER="

@@ -0,0 +1,77 @@
{
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "ArcLed130Tri",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "ArcLed130Tri",
"name": "ARCLED7314TRI",

Comment on lines +22 to +24
"dimensions": [240, 210, 160],
"weight": 2.5,
"power": 35,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dimensions": [240, 210, 160],
"weight": 2.5,
"power": 35,
"dimensions": [245, 205, 245],
"weight": 4.8,
"power": 52,

Comment on lines +58 to +59
"name": "4ch",
"shortName": "4ch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "4ch",
"shortName": "4ch",
"name": "4-channel",
"shortName": "Ar1.d",

Comment on lines +68 to +69
"name": "3ch",
"shortName": "3ch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "3ch",
"shortName": "3ch",
"name": "3-channel",
"shortName": "Arc.1",

Comment on lines +16 to +18
],
"video": [
"https://www.youtube.com/watch?v=DRJFQzjOSVc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
],
"video": [
"https://www.youtube.com/watch?v=DRJFQzjOSVc"

Dead link.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks since I am new to this site how do I reopen in edit mode to add 9-Channel mode?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there isn't an easy way. But you could create new channels, view the JSON, and copy/paste them into a patch here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants