Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture rosco/x-effects-ho-rgbw #4560

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture rosco/x-effects-ho-rgbw

Thank you Tim Linamen!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Jan 16, 2025
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ rosco / x-effects-ho-rgbw: d-light / attributes-correctness
  • ✔️ rosco/x-effects-ho-rgbw-Normal.xml
✔️ rosco / x-effects-ho-rgbw: dmxcontrol3 / channel-numbers
  • ✔️ rosco-x-effects-ho-rgbw-Normal.xml
✔️ rosco / x-effects-ho-rgbw: dragonframe / json-schema-conformity
  • ✔️ rosco/x-effects-ho-rgbw.json
  • ✔️ manufacturers.json
✔️ rosco / x-effects-ho-rgbw: millumin / json-schema-conformity
  • ✔️ rosco/x-effects-ho-rgbw.json
rosco / x-effects-ho-rgbw: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Rosco-X-Effects-HO-RGBW.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
rosco / x-effects-ho-rgbw: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Rosco-X-Effects-HO-RGBW.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant