Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate out checkpoint tests for audit tests #30556

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from
Open

Seperate out checkpoint tests for audit tests #30556

wants to merge 1 commit into from
+164 −47

Conversation

tjwatson
Copy link
Member

@tjwatson
Copy link
Member Author

tjwatson commented Jan 14, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@tjwatson tjwatson requested a review from pgunapal January 15, 2025 03:01
@tjwatson
Copy link
Member Author

tjwatson commented Jan 15, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ⏳InProgress)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

pgunapal
pgunapal requested changes Jan 15, 2025
View reviewed changes
...ofile.telemetry.2.0.logging.internal_fat/publish/servers/TelemetryAuditCheckpoint/server.xml
@@ -0,0 +1,23 @@
<!--
Copyright (c) 2024 IBM Corporation and others.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this needs to be updated to 2025, or if config files even need a copyright header?

...metry.2.0.logging.internal_fat/publish/servers/TelemetryAuditCheckpoint/bootstrap.properties
@@ -0,0 +1,3 @@
bootstrap.include=../testports.properties
com.ibm.ws.logging.console.log.level=OFF
com.ibm.ws.logging.trace.specification=io.openliberty.microprofile.telemetry.internal.common=all:io.openliberty.microprofile.telemetry.logging.internal.fat.MpTelemetryLogApp.*=all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed, since we aren't checking for trace or even using the test app in the checkpoint test.

...io/openliberty/microprofile/telemetry/logging/internal_fat/TelemetryAuditCheckpointTest.java
@@ -0,0 +1,97 @@
/*******************************************************************************
* Copyright (c) 2024 IBM Corporation and others.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright year -> 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgunapal pgunapal pgunapal requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
noproductcode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjwatson @LibbyBot @pgunapal