Update Apache Commons Daemon prunsrv to 1-4-0 #30524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#build Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FZCjsdAmEe-f-sI4gb7_Pw Target locations of links might be accessible only to IBM employees. |
|
#libby Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new version of prunsrv.exe, there is a slight change of behavior for the registerWinService command when the server has been created, but never started. In that situation, there is no "logs" directory under the server directory,
("!WLP_OUTPUT_DIR!%SERVER_NAME%\logs). The previous version of prunsrv did not complain about that. The new version displays an warning/error message:
[2025-01-13 10:52:15] [warn] [12240] Failed to grant service user 'LocalSystem' write permissions to log path 'C:\wlp\usr\servers\<SERVER_NAME>\logs' due to error '2: The system cannot find the file specified.'To avoid the message in this scenario, I added a check to see if the directory exists before calling prunsrv to register the service. If the "logs" dir doesn't exist, the server.bat script will create it.