Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating Static Branch for FrontEnd Rendering #38

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

aishikanandi
Copy link
Collaborator

@aishikanandi aishikanandi commented Jan 5, 2024

Description

The PR is intended to disconnect the backend from the project and render the frontend using dummy data for initial testing with newer alternatives of backend for the project

Related Issue

Initiates starting point for #37

Motivation and Context

Backend has encountered some technical glitches.

All Submissions:
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
New Feature Submissions:
  1. Does your submission pass tests?

Tests not present yet. Manually tested by @tusharbansal22

  1. Have you lint your code locally prior to submission?
Changes to Core Features:
  • Have you added an explanation of what your changes do and why you'd like us to include them?
How Has This Been Tested?

Manually tested by @tusharbansal22

@aishikanandi aishikanandi changed the base branch from main to static January 5, 2024 13:53
@@ -191,7 +268,7 @@ export default function Courses() {
<p
onClick={() =>
router.push(
'/courses/' + course.id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural Change. not appropriate representation of current backend service.


const { privateKey } = JSON.parse(process.env.PRIVATE_KEY!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend Disconnected

@@ -13,6 +13,79 @@ import { useRouter } from 'next/router'
import { RiDeleteBin6Line } from 'react-icons/ri'
import { deleteCourse } from '../../services/db/courses/deleteCourse'

const dummyCourses = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data structure not synchronous with current models

Copy link
Member

@tusharbansal22 tusharbansal22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be used for demonstration purpose, sample data is not appropriate representation of current backend models

Copy link
Member

@tusharbansal22 tusharbansal22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging to static for creating starting point for #37

@tusharbansal22 tusharbansal22 merged commit 13fad26 into OpenLake:static Jan 5, 2024
@tusharbansal22 tusharbansal22 changed the title FossOverflow Ready Incorporating Static Branch for FrontEnd Rendering Jan 5, 2024
@tusharbansal22 tusharbansal22 added bug Something isn't working FossOverflow23-24 labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FossOverflow23-24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants