Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Do per repeat per leg results gathering #558

Closed
wants to merge 4 commits into from
Closed

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Sep 15, 2023

TODO:

  • Fix tests

Developers certificate of origin


for key in res['unit_results']:
dg = res['unit_results'][key]['outputs']['unit_estimate']
mbar_error = res['unit_results'][key]['outputs']['unit_estimate_error']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes things not backwards compatible, do we care?

@IAlibay
Copy link
Member Author

IAlibay commented Sep 15, 2023

@mikemhenry we're going to need a new version of rbfe_results.tar.gz - is this something you might be able to generate?

@mikemhenry
Copy link
Contributor

@IAlibay Yes, do you want me to make it with this branch?

@IAlibay
Copy link
Member Author

IAlibay commented Sep 22, 2023

@IAlibay Yes, do you want me to make it with this branch?

I don't think anything I've gone here will affect simulations, just the gathering. If we just do another run using the current main branch that should be fine.

@mikemhenry
Copy link
Contributor

Cool, doing that right now, assuming this commit is recent enough e2eeb85

@IAlibay
Copy link
Member Author

IAlibay commented Oct 7, 2023

Cool, doing that right now, assuming this commit is recent enough e2eeb85

@mikemhenry did you manage to generate these results?

@pep8speaks
Copy link

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 91:80: E501 line too long (87 > 79 characters)

@richardjgowers
Copy link
Contributor

done in #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants