-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Do per repeat per leg results gathering #558
Conversation
|
||
for key in res['unit_results']: | ||
dg = res['unit_results'][key]['outputs']['unit_estimate'] | ||
mbar_error = res['unit_results'][key]['outputs']['unit_estimate_error'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes things not backwards compatible, do we care?
@mikemhenry we're going to need a new version of |
@IAlibay Yes, do you want me to make it with this branch? |
I don't think anything I've gone here will affect simulations, just the gathering. If we just do another run using the current main branch that should be fine. |
Cool, doing that right now, assuming this commit is recent enough e2eeb85 |
@mikemhenry did you manage to generate these results? |
Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
done in #620 |
TODO:
Developers certificate of origin