Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gather - show all failed edges in error message #1095

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gather - show all failed edges in error message #1095

wants to merge 17 commits into from

Conversation

atravitz
Copy link
Contributor

@atravitz atravitz commented Jan 24, 2025 •
edited
Loading

Closes #1101

Checklist

  • Added a news entry

Developers certificate of origin

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (ccc28db) to head (6bffeb4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   94.62%   92.90%   -1.73%     
==========================================
  Files         136      137       +1     
  Lines       10087    10103      +16     
==========================================
- Hits         9545     9386     -159     
- Misses        542      717     +175
Flag Coverage Δ
fast-tests 92.90% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atravitz atravitz self-assigned this Jan 27, 2025
@atravitz atravitz force-pushed the output_all_failed_edges branch 2 times, most recently from 74e558b to bfe911e Compare January 27, 2025 20:24
@atravitz atravitz changed the title [WIP] Output all failed edges gather - show all failed edges in error message Jan 27, 2025
@atravitz atravitz marked this pull request as ready for review January 27, 2025 21:03
IAlibay
IAlibay requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but the error message seems like it might be a bit too unweildy.

Ideally we want something that's easy to parse for edges rather than a lot of text around each printed line.

openfecli/commands/gather.py Outdated
if maybe_rhfe and not maybe_rbfe:
msg += (
f"{ligpair}:\n"
"\tAssuming this is an RHFE calculation, "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might get really noisy, with lots of Assuming X this is missing. Could we just set that as a single header and then just += on a list of edge information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jthorton @IAlibay how do you feel about this solution?

Here's what the output looks like:

image

My thinking is that we pass through as much info to the user as we can without trying to be overly clever and auto-detecting rbfe vs rhfe, since it sounds like verbosity hurts more than helps.

Happy to change it again in the future depending on user needs.

@atravitz atravitz force-pushed the output_all_failed_edges branch from fec49d6 to cae75d1 Compare January 29, 2025 00:10
@atravitz atravitz force-pushed the output_all_failed_edges branch from cae75d1 to f6c9ef8 Compare January 29, 2025 19:02
@github-actions GitHub Actions
Copy link

No API break detected ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@atravitz atravitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gather - show all failed edges in error message #1095
2 participants
@atravitz @IAlibay