Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, sorry for the delay, I ended up going on a trip as I am in my vacation.
Validation Steps
reference for the original bug https://www.loom.com/share/58feb3af170a42fdbe70a127843bb7cb
...
for thephx-disable-with
text.Notes for the reviewer
At the
lib/lightning_web/live/components/menu.ex
, github fails to diff in a good way. You can notice that the previous code is the same as in theelse
block, this should simplify the review.Related issue
Fixes #2212
Review checklist
:owner
,:admin
,:editor
,:viewer
) have been implemented and tested