-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intuit: Create generic get and post http helpers #949
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@hunterachieng if you need to update the template please do it in a separate PR :) And when you're ready for another review, please mark the PR as Ready |
Signed-off-by: Hunter Achieng <[email protected]>
@josephjclark We do not need to update the template as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small things!
"baseUrl": { | ||
"title": "Base URL", | ||
"type": "string", | ||
"description": "The Quickbooks(intuit) base URL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we default this? Can users even us different domains?
If our implementation is on the main intuit.com baseUrl, we should default it and leave this as optional
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
.changeset/tame-apricots-roll.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
'@openfn/language-intuit': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeset isn't needed for new adaptors - please delete this file and then we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Hunter Achieng <[email protected]>
Summary
Implement a new adaptor:
intuit
with genericget
andpost
http helpersFixes #827
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.