Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: remove callback, fix options #921

Merged
merged 1 commit into from
Jan 17, 2025
Merged

template: remove callback, fix options #921

merged 1 commit into from
Jan 17, 2025

Conversation

josephjclark
Copy link
Collaborator

Summary

Fix two important things in the template:

  1. remove callbacks as we're trying to phase them out
  2. Fix an issue where options isn't properly passed into common

Fixes #915

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@josephjclark josephjclark merged commit 5403fcc into main Jan 17, 2025
3 checks passed
@josephjclark josephjclark deleted the template-fixes branch January 17, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

generate-adaptor template: remove callbacks
1 participant