Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put instance_url at the root of configuration schema for Salesforce OAuth #473

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

elias-ba
Copy link
Contributor

@elias-ba elias-ba commented Feb 1, 2024

Summary

Update instance_url in oauth-configration-schema.json to be in the root of configuration schema for Salesforce OAuth. And update createAccessTokenConnection in adaptors.js

Issues

Ref #472

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@josephjclark
Copy link
Collaborator

We should:

  1. Deprecate the current latest version on npm, because it won't work with Lightning
  2. In Lightning, find a way to automatically ignore/block deprecated adaptor versions

@mtuchi
Copy link
Collaborator

mtuchi commented Feb 2, 2024

  1. Deprecate the current latest version on npm, because it won't work with Lightning ✅

I have deprecate @openfn/[email protected] cc @elias-ba
Screenshot 2024-02-02 at 12 36 49 PM

@mtuchi mtuchi merged commit 3221ada into main Feb 2, 2024
1 check passed
@mtuchi mtuchi deleted the 472-update-salesforce-oauth branch February 2, 2024 10:34
mtuchi added a commit that referenced this pull request Mar 19, 2024
… OAuth (#473)

* Remove instance_url under other_params and put it at the root level of the configuration schema

* version bump and update changelog

---------

Co-authored-by: Emmanuel Evance <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants