Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 947 by updating the usage of cookie-parser dependency #991

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

moll0928
Copy link
Contributor

@moll0928 moll0928 commented Aug 21, 2023

Description

Delete the cookie-parser dependency after testing its usage and upload its usage in the app.js.

Fixes #947

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request

Limitations

@moll0928 moll0928 changed the title Development Fix Issue 947 by updating the usage of cookie-parser dependency Aug 21, 2023
@moll0928 moll0928 changed the title Fix Issue 947 by updating the usage of cookie-parser dependency Fix issue 947 by updating the usage of cookie-parser dependency Aug 21, 2023
@moll0928
Copy link
Contributor Author

moll0928 commented Aug 21, 2023

Done with @1jc

@huss
Copy link
Member

huss commented Aug 21, 2023

Since this work was done with @1jc, OED needs a contributor license agreement from them too. My records do not show them as having completed CLA. Please let me know if I am mistaken about this.

@huss
Copy link
Member

huss commented Aug 21, 2023

I did a few edits of the description. I tested and reviewed the changes and all seems good. This is ready to merge once the other CLA is submitted.

@huss huss self-assigned this Aug 21, 2023
@1jc
Copy link

1jc commented Aug 21, 2023

@1jc did CLA and submitted @huss you can merge now

@1jc
Copy link

1jc commented Aug 21, 2023 via email

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @moll0928 and @1jc for their first contribution to OED. The changes look good and testing found no problems.

@huss huss merged commit 4388f54 into OpenEnergyDashboard:development Aug 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cookie-parser usage
3 participants