Enable reading validation via admin input #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into new_UI_setChecks
The TypeScript compiler was throwing errors because it couldn't find the properties 'min' and 'max' on the type 'BarReading'. The issue arises because TypeScript is unaware that 'min' and 'max' are only accessed when 'readings' is an array of 'LineReadings'. This commit adds a type guard to explicitly inform TypeScript about the type of 'reading', resolving the issue.
Fixed for a comment that was not clear in my review to resolve this.
|
I made a few minor changes to the code. I don't think there are any issues but I'll give others one day to see if there are any issues before I merge this code. |
huss
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
I want to thank all the developers of this code for being willing to implement additional features after the pull request was created, being so careful in finding a few things I missed and the speed with which they did all their work. The changes address all the comments and testing has found this to work well. This code is now ready to merge. Congratulations on your first contribution to OED.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, readings are not validated upon upload. This PR enables an admin to define default test values, which are then executed when readings are uploaded. The admin panel, meter modal (create/edit), meter object and database have been modified to accommodate these values. The conditionSet object was previously undefined, but can now be determined using these values and enable readings to be validated.
@TrongQuocLe @codehomie1
Fixes #511
Type of change
Checklist
Limitations
Written test cases need to be created.