Bugfix for loss of map graph display when in mobile #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bug fix removes the styling
alignItems: 'center'
from thediv
wrapper around thePlotNavComponent
, which displays the graphs in the application. With this change, the entire map should be available via scrolling.Explanation for bug:
The styling did not affect other maps as they were drawn using
Plot
while considering the viewport's width and height in terms of percentages (100% of width and height). The styling caused this bug for map graphs because an image is used (which is not adjusted to the viewport's height and width), and the styling caused the "start" of the map to be at the center.Fixes #1347
Type of change
N/A
Checklist
Limitations
No limitations
Manual Tests Done
I manually tested the app's behavior pre and post fix for both desktop and mobile viewport, considering:
Note: Happy to provide screenshots of all other maps still working properly, but will only upload the working map view to start with unless more is requested.
post-fix-map-mobile.mov