Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test case BG7 #1380

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

BigGeF
Copy link
Contributor

@BigGeF BigGeF commented Nov 4, 2024

Description

Added BG7 test case in readingsBarGroupQuantity.js
Added file expected_bar_group_ri_15-20_mu_kWh_gu_kWh_st_2022-08-20%07#25#35_et_2022-10-28%13#18#28_bd_13.csv

Mason Sain - @sainmas
Evan Thomas - @ethomas5
Pedro Valdovinos Reyes - @PValdovinos

Partly addresses #692

Fixes #[issue]

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @BigGeF, @sainmas, @ethomas5 & @PValdovinos for their first contribution to OED. Testing and review found it works as expected. I did make a few comments that I would appreciate your response/action.

package-lock.json Outdated Show resolved Hide resolved
src/server/test/web/readingsBarGroupQuantity.js Outdated Show resolved Hide resolved
src/server/test/web/readingsBarGroupQuantity.js Outdated Show resolved Hide resolved
@ethomas5
Copy link
Contributor

ethomas5 commented Nov 5, 2024

@huss Not sure if resolving the changes pinged you on this, but just letting you know we got the PR comments addressed (hopefully).

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the team of @BigGeF, @sainmas, @ethomas5 & @PValdovinos for quickly addressing the comments. Review and testing found that all is in order. Congratulations on your first accepted contribution to OED.

@huss huss merged commit 360854a into OpenEnergyDashboard:development Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants