Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated ThreeD, Radar, Map area calculation method #1379

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

hinyan17
Copy link
Contributor

@hinyan17 hinyan17 commented Nov 3, 2024

Description

Updated the method of area calculation / normalization in ThreeD, Radar, and Map components. They used to calculate area individually, but now call functions from src/client/app/redux/selectors/entitySelectors.ts to do so. This is now consistent across all components. Line and Bar are unchanged because they already follow this method. MultiCompare doesn't need to.

Fixes #1200

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

none

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @hinyan17 for another contribution to OED. Review and testing found it works as expected. I have made one small comment to consider.

src/client/app/components/MapChartComponent.tsx Outdated Show resolved Hide resolved
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @hinyan17 for the quick update. Everything looks good. Thanks for another accepted contribution.

@huss huss merged commit c5d555f into OpenEnergyDashboard:development Nov 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consistent area calculation for graphics
2 participants