Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed CG16 Test Case #1378

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Conversation

K-coder05
Copy link

Description

Added CG16 test case in src/server/test/web/readingsCompareGroupFlow.js

Khiem Nguyen - @K-coder05
Ben Khong - @benkhong27
Newton Chung - @NewtonLC

Partly Addresses #962

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

@huss
Copy link
Member

huss commented Nov 3, 2024

Thanks to @K-coder05, @benkhong27 & @NewtonLC for their first contribution to OED. I know this is labeled as a draft but I looked at it. It is fine. The only change that is needed is to update to the latest expected values in the design doc. As recently noted on Discord Developer channel, there was a mistake in the values and I offered to fix up the impacted cases. However, I wanted to see if you prefer to do that or if you would prefer me to make the change to this PR. Also, I think it is fine to convert this from draft to a regular PR if you are willing as it is ready to merge after that change.

@K-coder05
Copy link
Author

We have updated the changes for the latest expected values in the design doc. Apologies, we thought we made this change already after looking on the Discord Developer channel and the new comments made issue #962. Thank you for the feedback.

@K-coder05 K-coder05 marked this pull request as ready for review November 3, 2024 17:18
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks for the quick update due to the design doc change. Congratulations to @K-coder05, @benkhong27 & @NewtonLC on you first accepted contribution to OED.

@huss huss merged commit 14becf4 into OpenEnergyDashboard:development Nov 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants