Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test Case BG16 #1373

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Conversation

MatthewTran22
Copy link
Contributor

Description

Added Test Case BG16 into readingsBarGroupFlow.js

Partially Addresses #962

Co-Authors:
@darvr1
@suchithgali

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

None of Test Case BG16

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @MatthewTran22, @darvr1 & @suchithgali for their first contribution to OED. Review and testing found it works as expected. This is only a comment since my records do not indicate that @darvr1 has signed the OED CLA (See https://openenergydashboard.org/developer/cla/) but the box is checked above. Please let me know if you think my records are off. Once this is resolved the code should be able to merge.

@darvr1
Copy link
Contributor

darvr1 commented Oct 28, 2024

I re-signed the OED CLA. Please check again, and let me know if everything looks good. Thank you for your patience.

@huss
Copy link
Member

huss commented Oct 28, 2024

I re-signed the OED CLA. Please check again, and let me know if everything looks good. Thank you for your patience.

Thanks for doing the CLA. All is good.

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Congratulations to @MatthewTran22, @darvr1 & @suchithgali for their first accepted contribution to OED.

@huss huss merged commit 0b137f4 into OpenEnergyDashboard:development Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants