-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Test Case BG16 #1373
Added Test Case BG16 #1373
Conversation
TODO: verify that name and unit are correct
Co-authored-by: Matthew Tran <[email protected]> Co Co-authored-by: Suchith Gali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @MatthewTran22, @darvr1 & @suchithgali for their first contribution to OED. Review and testing found it works as expected. This is only a comment since my records do not indicate that @darvr1 has signed the OED CLA (See https://openenergydashboard.org/developer/cla/) but the box is checked above. Please let me know if you think my records are off. Once this is resolved the code should be able to merge.
I re-signed the OED CLA. Please check again, and let me know if everything looks good. Thank you for your patience. |
Thanks for doing the CLA. All is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Congratulations to @MatthewTran22, @darvr1 & @suchithgali for their first accepted contribution to OED.
Description
Added Test Case BG16 into readingsBarGroupFlow.js
Partially Addresses #962
Co-Authors:
@darvr1
@suchithgali
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
None of Test Case BG16